-
Notifications
You must be signed in to change notification settings - Fork 745
Implement automatic .NET SDK installation for Aspire CLI #12188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6701b89
Initial plan
Copilot 7c0b33a
Implement automatic .NET SDK installation feature
Copilot a1a0549
Refactor RuntimesDirectory to use CliExecutionContext for better test…
Copilot b3ea029
Fix test compilation issues for RuntimesDirectory refactoring
Copilot 3983f38
Add feature flag for SDK installation (dotnetSdkInstallationEnabled)
Copilot 70cdfde
Add alwaysInstallSdk configuration for testing SDK installation
Copilot f902d94
Use GetRequiredService and expand IDotNetSdkInstaller interface
Copilot 84aea89
Fix tests.
7713858
Prepend private SDK path to PATH environment variable
Copilot c2d1186
Add logging to DotNetSdkInstaller for installation output
Copilot fec0153
Set rollforward policy and prepend path to filename.
744eb29
Skip package prefetching when SDK is not installed
Copilot 18d1dcd
Try pwsh before powershell for better cross-platform support
Copilot 3ca0bf8
Add DOTNET_NOLOGO=1 environment variable to suppress welcome message
Copilot 2fc0863
Check for private SDK installation before prompting
Copilot e23dc73
Verify private SDK by calling GetNuGetConfigPathsAsync
Copilot eaf74a0
Move SDK installation logic and change path from runtimes to sdks
Copilot 38ea4a5
Change feature flag default to false and update SDK version to RC2
Copilot 8fd320b
Apply suggestions from code review
davidfowl 5cf5518
Use Path.PathSeparator instead of platform-specific logic
Copilot 47d2b3d
Use File.SetUnixFileMode and wrap InstallAsync in ShowStatusAsync
Copilot b1b004c
Restore original message text for SDK installation
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.