Add missing end quote for Outputs declaration#10289
Merged
radical merged 1 commit intodotnet:mainfrom Jul 9, 2025
Merged
Conversation
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a syntax error in the MSBuild Outputs attribute for the _ProcessTextReplacementFiles target to ensure proper output tracking and prevent unnecessary rebuilds.
- Corrects a missing closing quote in the
Outputsmetadata transform. - Restores valid MSBuild expression so outputs are recognized.
Comments suppressed due to low confidence (1)
eng/ReplaceText.targets:62
- The transform string in the
Outputsattribute was missing its closing quote, causing MSBuild to treat it as an invalid expression and always rebuild. This addition correctly closes the quote so MSBuild can detect outputs properly.
Outputs="@(_TextReplacementFile->'%(_TextReplacementIntermediateFile)')"
radical
approved these changes
Jul 9, 2025
Member
radical
left a comment
radical
left a comment
There was a problem hiding this comment.
Thank you for the contribution! LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_ProcessTextReplacementFilestarget specifies an invalid expression in itsOutputsattribute leading to MSBuild not properly checking the output and always rebuilding this target. This was found while prototyping a new set of functionality in MSBuild that is more strict about input and output declarations and failed on this.