Skip to content

Change owner of uploaded files to helix-runner in Apple XHarness workloads #7986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
premun merged 1 commit into from
Oct 4, 2021
Merged

Change owner of uploaded files to helix-runner in Apple XHarness workloads #7986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/xharness-runner.apple.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ if [ $exit_code -eq 86 ]; then
fi

# The simulator logs comming from the sudo-spawned Simulator.app are not readable/deletable by the helix uploader
sudo chown -R helix-runner "$output_directory"
Copy link
Member

@MattGal MattGal Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helix-runner should be $(whoami). The helix user's name is arbitrary and could vary in the future, but you know that the current work item is that users.

Copy link
Member Author

@premun premun Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking about that, to store it in a variable first and then use it here. I just want to see it work first though.

Will note it down and change

chmod -R 0766 "$output_directory"

# Remove empty files
Expand Down