-
Notifications
You must be signed in to change notification settings - Fork 378
Adding detection and retargeting of DOTNETHOME #7785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
7c6da78
c7253be
74dfcbe
ffecbc5
2e18fca
fc8f01d
a56034a
463682f
b9fc8d7
9c44c75
f29f187
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. --> | ||
| <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi"> | ||
| <?ifndef Platform ?> | ||
| <?define Platform = "$(sys.BUILDARCH)" ?> | ||
| <?endif ?> | ||
|
|
||
| <!-- The following match the expected values for PROCESSOR_ARCHITECTURE | ||
| https://docs.microsoft.com/en-us/windows/win32/winprog64/wow64-implementation-details --> | ||
| <?if $(var.Platform)=x86?> | ||
| <?define InstallerArchitecture="X86"?> | ||
| <?elseif $(var.Platform)=x64?> | ||
| <?define InstallerArchitecture="AMD64"?> | ||
| <?elseif $(var.Platform)=ARM64?> | ||
| <?define InstallerArchitecture="ARM64"?> | ||
| <?endif?> | ||
ericstj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| <Fragment> | ||
| <!-- Identify when installing in emulation as when PROCESSOR_ARCHITECTURE does not match the installer architecture | ||
| https://docs.microsoft.com/en-us/windows/win32/winprog64/wow64-implementation-details --> | ||
| <SetProperty Action="Set_INSTALLING_IN_EMULATION" Id="INSTALLING_IN_EMULATION" Value="true" Before="CostFinalize"> | ||
| NOT %PROCESSOR_ARCHITECTURE="$(var.InstallerArchitecture)" | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Once we have wixtoolset/issues#6556 this goes away.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'll need to port this into release/6.0 as well I think since Arcade snapped and main now targets 7.0 FYI @pjcollins this will impact maui workload pack generation
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Right, that's the plan here: #7785 (comment) |
||
| </SetProperty> | ||
| </Fragment> | ||
|
|
||
| <?if $(var.Platform)=x64?> | ||
| <Fragment> | ||
| <!-- When running in x64 emulation and user hasn't specified install directory, install to an x64 subdirectory--> | ||
| <SetProperty Action="Set_DOTNETHOME_x64" Id="DOTNETHOME" Value="[ProgramFiles64Folder]dotnet\x64\" After="Set_INSTALLING_IN_EMULATION"> | ||
ericstj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| INSTALLING_IN_EMULATION AND NOT DOTNETHOME | ||
| </SetProperty> | ||
| </Fragment> | ||
| <?endif?> | ||
| </Wix> | ||
Uh oh!
There was an error while loading. Please reload this page.