Bump codeanalysisVersion to make it understand nullablity #4796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiriktsarpalis
approved these changes
Feb 10, 2020
ericstj
approved these changes
Feb 10, 2020
Member
|
Hi @Anipik, has the change been incorporated in dotnet/runtime? I see that the package was recently updated in a PR. However my PR is still failing, even though I rebased on top of the latest master: |
Contributor
Author
|
@eiriktsarpalis I am just debugging your change to see what causing this. |
Contributor
Author
|
@eiriktsarpalis the change from arcade have not yet merged into the corefx dotnet/runtime#32115 this contains the arcade change. @ViktorHofer is trying to get the pr merged. |
Member
|
Can confirm that the issue has been fixed in my branch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I published the package locally and tested it by building runtime repo that the msbuild version of codeAnalysis doesn't interfere with this one.