Skip to content

Conversation

@ViktorHofer
Copy link
Member

To double check:

@ViktorHofer ViktorHofer requested a review from mmitche July 11, 2023 17:11
<PropertyGroup>
<IncludeDotNetCli Condition=" '$(IncludeDotNetCli)' != 'true' ">false</IncludeDotNetCli>
<AspNetCoreRuntimeVersion>8.0.0-preview.5.23302.2</AspNetCoreRuntimeVersion>
<AspNetCoreRuntimeVersion>8.0.0-preview.6.23329.11</AspNetCoreRuntimeVersion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the version mentioned here: https://dotnet.microsoft.com/en-us/download/dotnet/8.0. Is that the correct one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's correct. Unhelpfully, aspnet and runtime had the same version number in p5. Either way, it'll fail if it's wrong.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jul 11, 2023

@agocke PTAL

src/Microsoft.DotNet.XUnitAssert/src/EqualityAsserts.cs(332,5): error IL2091: 'T' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.Interfaces' in 'Xunit.Assert.Equal(T, T, IEqualityComparer)'. The generic parameter 'T' of 'Xunit.Assert.StrictEqual(T, T)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to.

@ViktorHofer ViktorHofer enabled auto-merge (squash) July 11, 2023 22:16
@ViktorHofer ViktorHofer merged commit f52865b into main Jul 12, 2023
@akoeplinger akoeplinger deleted the ViktorHofer-patch-1 branch October 17, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants