Bump xamarin-android-tools from bde49e6 to 4889bf0.
#8545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
microsoft-build-xat-test
branch
2 times, most recently
from
ab8ab2b to
d08b398
Compare
Member
|
@jpobst would you want to update this one to use xamarin-android-tools/main now? |
jpobst
force-pushed
the
microsoft-build-xat-test
branch
from
d08b398 to
f818ef5
Compare
jpobst
changed the title
xamarin-android-tools from bde49e6 to 4889bf0.
Member
jpobst
force-pushed
the
microsoft-build-xat-test
branch
5 times, most recently
from
bd4e3a6 to
af32ad8
Compare
Member
…match new `$(MSBuildPackageReferenceVersion)`.
jpobst
force-pushed
the
microsoft-build-xat-test
branch
from
af32ad8 to
a5469cb
Compare
jpobst
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
jonathanpeppers
approved these changes
Dec 5, 2023
jpobst
added a commit
that referenced
this pull request
Dec 6, 2023
Context: dotnet/android-tools#220 Context: #8545 We added the ability for consumers of MSBuild NuGet packages to not add the `Microsoft.Build` package to their project. One project that currently still requires `Microsoft.Build` is `Xamarin.Android.BootstrapTasks`. However the only thing that uses `Microsoft.Build` is `TimingLogger` which produced a build performance report for our old Jenkins build system. As we no longer use Jenkins or this code, removing it allows us to remove the `Microsoft.Build` dependency. Removes warnings: ``` C:\a\_work\1\s\build-tools\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks.csproj : warning NU1701: Package 'Microsoft.Build 17.8.3' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project. [C:\a\_work\1\s\Xamarin.Android.BootstrapTasks.sln] C:\a\_work\1\s\build-tools\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks.csproj : warning NU1701: Package 'Microsoft.IO.Redist 6.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project. [C:\a\_work\1\s\Xamarin.Android.BootstrapTasks.sln] ``` This reduces the number of CI reported warnings from 166 to 56.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump
xamarin-android-toolsfrombde49e6to4889bf0.With dotnet/android-tools#220, we now need to set
$(_IncludeMicrosoftBuildPackage)for projects that need aMicrosoft.Buildreference.This bump fixes 226 CI reported warnings (390 -> 164).