Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 21, 2021

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NET.ILLink.Tasks: from 6.0.100-preview.6.21304.2 to 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NETCore.App.Ref: from 6.0.0-preview.6.21306.1 to 6.0.0-preview.6.21317.12 (parent: Microsoft.Dotnet.Sdk.Internal)

From https://github.com/dotnet/installer

  • Subscription: c771bbf1-d89e-42bb-f9af-08d9301a7704
  • Build: 20210623.1
  • Date Produced: 6/23/2021 8:22 AM
  • Commit: 12636f6fdf5aa015bc0a1183936e5458f9ae85e3
  • Branch: refs/heads/release/6.0.1xx-preview6

…210620.7

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.6.21313.2 -> To Version 6.0.100-preview.6.21320.7

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.6.21304.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal
Context: dotnet/runtime#53811

dotnet/runtime#53811 is now solved, so we can remove the workaround.
@dotnet-maestro dotnet-maestro bot requested a review from dellis1972 as a code owner June 21, 2021 15:38
@jonathanpeppers
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…210621.13

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.6.21313.2 -> To Version 6.0.100-preview.6.21321.13

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.6.21304.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal
Context: dotnet/msbuild#6609

It seems that properties are missing from MSBuild logs, ignoring part of this test for now.
dotnet-maestro bot and others added 2 commits June 23, 2021 12:32
…210623.1

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.6.21313.2 -> To Version 6.0.100-preview.6.21323.1

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.NETCore.App.Ref
 From Version 6.0.100-preview.6.21304.2 -> To Version 6.0.100-preview.6.21314.2 (parent: Microsoft.Dotnet.Sdk.Internal
Context: dotnet/templating#3325
Context: https://github.com/dotnet/templating/wiki/Reference-for-template.json#content-manipulation

In the current bump, `dotnet new android` + `dotnet build` fails with:

    Resources\mipmap-xxxhdpi\ic_launcher_round.png error APT2000: failed reading from input: PNG chunk type 49444154 is too large: chunk length is 10836 but chunk starts at byte 45/8187.

The .NET templating system has a 'copyOnly' mode for files that do not
need any text replaced. This is a performance feature, but it also
happens to workaround this issue.

We should be doing this on `.png` files *anyway*, as we don't need
potential "text" to be replaced. I will probably need to make similar
changes in xamarin/xamarin-macios and dotnet/maui.
@jonathanpeppers jonathanpeppers merged commit 03b9194 into release/6.0.1xx-preview6 Jun 23, 2021
@jonathanpeppers jonathanpeppers deleted the darc-release/6.0.1xx-preview6-565bfe6c-0e2c-4495-b959-98023e82e96c branch June 23, 2021 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants