Skip to content

[fix-finder] Fix Java properties default encoding - #12838

Merged
simonrozsival merged 1 commit into
mainfrom
copilot/fix-java-properties-encoding-0d8dd03e28f0fa43
Sep 21, 2026
Merged

simonrozsival merged 1 commit into
mainfrom
copilot/fix-java-properties-encoding-0d8dd03e28f0fa43

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

AI-generated fix. Produced by the nightly-fix-finder agentic workflow.

Problem

The bundled Java properties reader and writer claimed to use ISO-8859-1, the encoding required by the Java .properties format, but selected code page 28592 (ISO-8859-2). As a result, unescaped bytes in the 0x80-0xFF range were interpreted using the wrong character set.

Fix

Use code page 28591 for JavaProperties.DefaultEncoding, share that encoding with JavaPropertyWriter, and remove the resolved code-page TODO. The reader documentation now also identifies the correct encoding and code page.

Validation

  • AndroidSdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-sdk" AndroidNdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-ndk" ./build.sh Prepare — passed
  • ./dotnet-local.sh build src/Xamarin.Installer.AndroidSDK/Xamarin.Installer.AndroidSDK.csproj — passed with 0 warnings and 0 errors
  • Temporary smoke harness loading byte 0xA1 through JavaProperties.Load — passed, producing ISO-8859-1 U+00A1 rather than ISO-8859-2 U+0104
  • git diff --check — passed

Fix-finder metadata

  • Script: 00-todo-fixme-hack
  • Score: 27/30 (actionability: 10, safety: 8, scope: 9)

Generated by Nightly Fix Finder · copilot · gpt56 · 55.3 AIC · ⌖ 23 AIC · ⊞ 20.3K · ◷

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival merged commit f7876f7 into main Sep 21, 2026
44 checks passed
@simonrozsival
simonrozsival deleted the copilot/fix-java-properties-encoding-0d8dd03e28f0fa43 branch September 21, 2026 09:04
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant