Repository navigation
[fix-finder] Fix Java properties default encoding - #12838
Merged
simonrozsival merged 1 commit intoSep 21, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
requested review from
jonathanpeppers and
simonrozsival
as code owners
September 21, 2026 02:05
simonrozsival
approved these changes
Sep 21, 2026
simonrozsival
deleted the
copilot/fix-java-properties-encoding-0d8dd03e28f0fa43
branch
September 21, 2026 09:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bundled Java properties reader and writer claimed to use ISO-8859-1, the encoding required by the Java
.propertiesformat, but selected code page28592(ISO-8859-2). As a result, unescaped bytes in the0x80-0xFFrange were interpreted using the wrong character set.Fix
Use code page
28591forJavaProperties.DefaultEncoding, share that encoding withJavaPropertyWriter, and remove the resolved code-page TODO. The reader documentation now also identifies the correct encoding and code page.Validation
AndroidSdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-sdk" AndroidNdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-ndk" ./build.sh Prepare— passed./dotnet-local.sh build src/Xamarin.Installer.AndroidSDK/Xamarin.Installer.AndroidSDK.csproj— passed with 0 warnings and 0 errors0xA1throughJavaProperties.Load— passed, producing ISO-8859-1U+00A1rather than ISO-8859-2U+0104git diff --check— passedFix-finder metadata
00-todo-fixme-hack27/30(actionability:10, safety:8, scope:9)