Repository navigation
[fix-finder] Enable nullable annotations for LLVM attribute set - #12812
Merged
simonrozsival merged 1 commit intoSep 17, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
simonrozsival
approved these changes
Sep 17, 2026
simonrozsival
deleted the
nightly/nullable-function-attribute-set-dce1373eaba9b2e9
branch
September 17, 2026 06:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LlvmIrFunctionAttributeSetlacked an explicit nullable context, and its equality methods used non-nullable parameters even though both methods intentionally accept and rejectnull. This made their contracts inconsistent with their implementations and nullable equality conventions.Fix
Enabled nullable reference types in
LlvmIrFunctionAttributeSet.csand marked theIEquatable<T>.Equalsandobject.Equalsparameters nullable. The change is annotation-only and preserves existing equality behavior.Validation
AndroidSdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-sdk" AndroidNdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-ndk" ./build.sh Prepare— passed./dotnet-local.sh, then ran./dotnet-local.sh build src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj --no-restore -p:BuildProjectReferences=false -p:UseSharedCompilation=false -m:1with the prepared SDK/NDK paths — passed with 0 errorsgit diff --check— passedFix-finder metadata
01-nullable-reference-types30/30(actionability:10, safety:10, scope:10)