Skip to content

[fix-finder] Enable nullable annotations for LLVM attribute set - #12812

Merged
simonrozsival merged 1 commit into
mainfrom
nightly/nullable-function-attribute-set-dce1373eaba9b2e9
Sep 17, 2026
Merged

simonrozsival merged 1 commit into
mainfrom
nightly/nullable-function-attribute-set-dce1373eaba9b2e9

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

AI-generated fix. Produced by the nightly-fix-finder agentic workflow.

Problem

LlvmIrFunctionAttributeSet lacked an explicit nullable context, and its equality methods used non-nullable parameters even though both methods intentionally accept and reject null. This made their contracts inconsistent with their implementations and nullable equality conventions.

Fix

Enabled nullable reference types in LlvmIrFunctionAttributeSet.cs and marked the IEquatable<T>.Equals and object.Equals parameters nullable. The change is annotation-only and preserves existing equality behavior.

Validation

  • AndroidSdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-sdk" AndroidNdkDirectory="$GITHUB_WORKSPACE/bin/Debug/android-ndk" ./build.sh Prepare — passed
  • Built the three missing prerequisite assemblies individually through ./dotnet-local.sh, then ran ./dotnet-local.sh build src/Xamarin.Android.Build.Tasks/Xamarin.Android.Build.Tasks.csproj --no-restore -p:BuildProjectReferences=false -p:UseSharedCompilation=false -m:1 with the prepared SDK/NDK paths — passed with 0 errors
  • git diff --check — passed

Fix-finder metadata

  • Script: 01-nullable-reference-types
  • Score: 30/30 (actionability: 10, safety: 10, scope: 10)

Generated by Nightly Fix Finder · copilot · gpt56 · 62.4 AIC · ⌖ 12.8 AIC · ⊞ 24K · ◷

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival merged commit e56139f into main Sep 17, 2026
44 checks passed
@simonrozsival
simonrozsival deleted the nightly/nullable-function-attribute-set-dce1373eaba9b2e9 branch September 17, 2026 06:35
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant