Repository navigation
Localize the Android workload description - #12740
Merged
jonathanpeppers merged 4 commits intoSep 10, 2026
Merged
jonathanpeppers merged 4 commits into
jonathanpeppers merged 4 commits into
Conversation
Add the English workload localization catalog, wire OneLoc handoff generation, package and extract localized catalogs, and cover the English dotnet workload search output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are coherent across packing, extraction, localization discovery, and tests, with only minor follow-up suggestions.
Pull request overview
Adds workload-manifest localization support for the Android workload so dotnet workload search can display translated (and at least English) workload descriptions, aligning with the wasm-tools manifest pattern and enabling OneLoc-driven translation handbacks.
Changes:
- Introduces an English workload localization catalog (
WorkloadManifest.en.json) and packagesWorkloadManifest.<culture>.jsonunderdata/localize. - Updates local SDK manifest installation/extraction logic to preserve the
localizepayload. - Adds a CLI regression test and extends the test
DotNetCLIhelper to support env-var overrides anddotnet workload search.
File summaries
| File | Description |
|---|---|
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Common/DotNetCLI.cs | Adds per-invocation environment variable injection and a workload search helper for tests. |
| src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/XASdkTests.cs | Adds a regression test asserting English workload description presence and CLI output behavior. |
| src/Xamarin.Android.Build.Tasks/Microsoft.NET.Sdk.Android/localize/WorkloadManifest.en.json | Adds the English source catalog entry for the Android workload description. |
| Localize/update-locproject.ps1 | Broadens OneLoc discovery to include localize/*.en.json sources (not just templates). |
| build-tools/create-packs/Microsoft.NET.Sdk.Android.proj | Copies and packs workload localization JSON files into the manifest pack under data/localize. |
| build-tools/create-packs/Directory.Build.targets | Preserves data/localize contents when extracting manifest packs into local SDK layouts. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Place the test output beneath the shared temp directory so BaseTest.CleanupTest can find its cleanup root without walking past the filesystem root. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
jonathanpeppers
enabled auto-merge (squash)
September 9, 2026 20:12
simonrozsival
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dotnet workload searchlocalizes its table headings, but the Android workload description remains in English because the Android manifest package does not contain workload localization catalogs.This change follows the
wasm-toolsmanifest pattern fromdotnet/runtime: it adds the English catalog source, packages generatedWorkloadManifest.<culture>.jsonfiles underdata/localize, and preserves them when installing manifests into local SDK layouts. The existing OneLoc pipeline now discovers the English JSON source so localization bots can generate translated JSON and.lclhandbacks; no translated files are authored manually.A CLI regression test forces the English UI culture, verifies the installed English catalog, and checks that
dotnet workload search androiddisplays the expected description.Related to dotnet/sdk#27447.
Testing
data/localize/WorkloadManifest.en.jsonis included.Xamarin.Android.Build.Tests.csprojsuccessfully with the installed JDK paths supplied explicitly.