Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -97,23 +97,55 @@ public void Arrays ()
[Test]
public void JavaSideActivation ()
{
using (var i = new ConstructorTest ()) {
// To ensure that CallMethodFromCtor.class_ref is initialized
}
using (var c = Java.Lang.Class.FromType (typeof (ConstructorTest))) {
const int iterations = 100;
const int allowedGrefIncrease = 10;

// GlobalReferenceCount is process-wide. Warm the exact activation path before
// measuring so one-time runtime caches are not mistaken for per-call leaks.
for (int i = 0; i < iterations; i++) {
Comment thread
simonrozsival marked this conversation as resolved.
Resolved
AssertJavaSideActivation (c);
}
CollectGarbage ();

int initGref = Java.Interop.Runtime.GlobalReferenceCount;
using (var j = Com.Xamarin.Android.CallMethodFromCtor.NewInstance (c)) {
var instance = j.JavaCast<ConstructorTest>();
Assert.AreSame (j, instance);
Assert.IsTrue (instance.DefaultConstructorInvoked);
Assert.IsTrue (instance.ActivationConstructorInvoked);
for (int i = 0; i < iterations; i++) {
AssertJavaSideActivation (c);
}
CollectGarbage ();
int finiGref = Java.Interop.Runtime.GlobalReferenceCount;
Assert.AreEqual (initGref, finiGref,
string.Format ("Initial grefc={0}; final gref={1}; No GREFs should be lost!", initGref, finiGref));
int delta = finiGref - initGref;

// A known activation regression leaked three GREFs per call. Repeating the
// operation amplifies that to 300 while tolerating the observed ambient drift.
Assert.LessOrEqual (delta, allowedGrefIncrease,
string.Format ("GREF count increased by {0} after {1} Java-side activations. Initial grefc={2}; final grefc={3}.",
delta, iterations, initGref, finiGref));
}
}

static void AssertJavaSideActivation (Java.Lang.Class c)
{
using (var j = Com.Xamarin.Android.CallMethodFromCtor.NewInstance (c)) {
var instance = j.JavaCast<ConstructorTest>();
Assert.AreSame (j, instance);
Assert.IsTrue (instance.DefaultConstructorInvoked);
Assert.IsTrue (instance.ActivationConstructorInvoked);
}
Comment thread
simonrozsival marked this conversation as resolved.
Resolved
}

static void CollectGarbage ()
{
for (int i = 0; i < 3; i++) {
GC.Collect ();
GC.WaitForPendingFinalizers ();
}

Java.Interop.JniEnvironment.Runtime.ValueManager.CollectPeers ();
GC.WaitForPendingFinalizers ();
Java.Interop.JniEnvironment.Runtime.ValueManager.WaitForGCBridgeProcessing ();
Comment thread
simonrozsival marked this conversation as resolved.
Resolved
}
Comment thread
simonrozsival marked this conversation as resolved.
Resolved

//
// https://bugzilla.xamarin.com/show_bug.cgi?id=17630
// https://bugzilla.xamarin.com/show_bug.cgi?id=17750#c6
Expand Down Expand Up @@ -391,4 +423,3 @@ public class B : Java.Lang.Object {
}
}
}

Loading