Skip to content

[fix-finder] Enable nullable analysis for RunActivity - #12694

Merged
simonrozsival merged 1 commit into
mainfrom
fix-finder/runactivity-nullable-4c54d1d32bf6a4ff
Sep 7, 2026
Merged

simonrozsival merged 1 commit into
mainfrom
fix-finder/runactivity-nullable-4c54d1d32bf6a4ff

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

AI-generated fix. Produced by the nightly-fix-finder agentic workflow.

Problem

RunActivity.cs was not opted into nullable reference type analysis, leaving required MSBuild inputs and device initialization state without explicit nullability contracts.

Fix

Enabled nullable analysis in src/Xamarin.Android.Build.Debugging.Tasks/Tasks/RunActivity.cs, initialized required string properties, marked the optional ADB target and deferred device field nullable, and explicitly guarded the task lifecycle before device use.

Validation

  • AndroidSdkDirectory=/tmp/gh-aw/agent/android-sdk AndroidNdkDirectory=/tmp/gh-aw/agent/android-ndk AndroidToolchainDirectory=/tmp/gh-aw/agent/android-toolchain ./build.sh Prepare — passed
  • AndroidSdkDirectory=/tmp/gh-aw/agent/android-sdk AndroidNdkDirectory=/tmp/gh-aw/agent/android-ndk AndroidToolchainDirectory=/tmp/gh-aw/agent/android-toolchain ./dotnet-local.sh build src/Xamarin.Android.Build.Debugging.Tasks/Xamarin.Android.Build.Debugging.Tasks.csproj — passed with 0 warnings and 0 errors

Fix-finder metadata

  • Script: 01-nullable-reference-types
  • Score: 27/30 (actionability: 9, safety: 8, scope: 10)

Generated by Nightly Fix Finder · gpt56 · 130.6 AIC · ⌖ 43.2 AIC · ⊞ 23.8K · ◷

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival merged commit e5582e8 into main Sep 7, 2026
44 checks passed
@simonrozsival
simonrozsival deleted the fix-finder/runactivity-nullable-4c54d1d32bf6a4ff branch September 7, 2026 11:16
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant