Repository navigation
[fix-finder] Enable nullable analysis for RunActivity - #12694
Merged
simonrozsival merged 1 commit intoSep 7, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
simonrozsival
approved these changes
Sep 7, 2026
simonrozsival
deleted the
fix-finder/runactivity-nullable-4c54d1d32bf6a4ff
branch
September 7, 2026 11:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RunActivity.cswas not opted into nullable reference type analysis, leaving required MSBuild inputs and device initialization state without explicit nullability contracts.Fix
Enabled nullable analysis in
src/Xamarin.Android.Build.Debugging.Tasks/Tasks/RunActivity.cs, initialized required string properties, marked the optional ADB target and deferred device field nullable, and explicitly guarded the task lifecycle before device use.Validation
AndroidSdkDirectory=/tmp/gh-aw/agent/android-sdk AndroidNdkDirectory=/tmp/gh-aw/agent/android-ndk AndroidToolchainDirectory=/tmp/gh-aw/agent/android-toolchain ./build.sh Prepare— passedAndroidSdkDirectory=/tmp/gh-aw/agent/android-sdk AndroidNdkDirectory=/tmp/gh-aw/agent/android-ndk AndroidToolchainDirectory=/tmp/gh-aw/agent/android-toolchain ./dotnet-local.sh build src/Xamarin.Android.Build.Debugging.Tasks/Xamarin.Android.Build.Debugging.Tasks.csproj— passed with 0 warnings and 0 errorsFix-finder metadata
01-nullable-reference-types27/30(actionability:9, safety:8, scope:10)