Repository navigation
[ci] Govern dnceng internal pipeline - #12530
Conversation
Migrate dotnet-android-internal to the official 1ES Pipeline Template while preserving its stage graph, internal pool images, signing flow, and artifacts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR migrates the internal dotnet-android-internal Azure DevOps pipeline (build-tools/automation/azure-pipelines-internal.yaml) to the governed 1ES Official pipeline template, while keeping the existing stage graph and artifact outputs compatible with the current production definition.
Changes:
- Switch the internal pipeline from a raw
stages:graph toextends: v1/1ES.Official.PipelineTemplate.yml@1ESPipelineTemplatesand move artifact publishing totemplateContext/1ES.PublishPipelineArtifact@1. - Add an opt-in switch in the package test stage template to use a “public” setup template (avoids internal-only checkout template dependencies).
- Update
setup-test-environment-public.yamlto passuse1ESTemplatethrough to its underlying steps template.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build-tools/automation/yaml-templates/stage-package-tests.yaml | Adds a toggle to select the public vs. internal setup template for package test stages. |
| build-tools/automation/yaml-templates/setup-test-environment-public.yaml | Makes use1ESTemplate configurable instead of hard-coded false. |
| build-tools/automation/azure-pipelines-internal.yaml | Migrates the production internal pipeline to the governed 1ES Official template and updates artifact publishing/signing integration accordingly. |
Suppressed comments (1)
build-tools/automation/yaml-templates/stage-package-tests.yaml:120
⚠️ maintainability — Same as above for the second macOS APK test job: enablingusePublicSetupTemplatechanges implicit defaults (JDK version selection anduseAgentJdkPath) compared tosetup-test-environment.yaml. Passing them explicitly here helps preserve behavior while avoiding the private checkout template dependency.
- ${{ if eq(parameters.usePublicSetupTemplate, true) }}:
- template: /build-tools/automation/yaml-templates/setup-test-environment-public.yaml
parameters:
use1ESTemplate: ${{ parameters.use1ESTemplate }}
Keep the existing DefaultJavaSdkMajorVersion and agent JDK behavior when package tests use the governed-compatible checkout path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Qualify repository-local templates explicitly now that the root pipeline extends the external 1ES template repository. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Exclude android-tools and maui from source scanning because they are external build and test inputs, matching the existing official pipeline behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Drop the unused android-tools resource and use the already-required MAUI repository to preserve multi-checkout path semantics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Internal validation completed: dnceng/internal build 3059110, testing commit Disk cleanup is validated: all 22 hosted macOS test jobs completed with zero low-disk warnings, and all downstream Windows/Linux/signing jobs passed. The run finished with 37 passed jobs and six unrelated/baseline failures:
The change uses the existing |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60a6ba42-9755-43ac-8d02-5380d84c5fd0
Remove preinstalled .NET SDKs before installing the pipeline-selected SDK in internal hosted macOS test matrices. This preserves the existing warning gate while preventing test artifact downloads from crossing the agent's low-disk threshold. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60a6ba42-9755-43ac-8d02-5380d84c5fd0
|
Internal validation completed: dnceng/internal build 3059110 tested commit The disk cleanup worked: all 22 hosted macOS test jobs completed with zero low-disk warnings, and all Windows, Linux, and signing jobs passed. The six failed jobs were unrelated to this change: five |
|
The JDK 25/lint test failures on internal are hopefully fixed by: |
|
@dalexsoto review |
Replace otherwise-unused MAUI checkouts with dotnet/macios-devtools while retaining MAUI where integration jobs consume it. Document that the extra checkout preserves the s/android multi-repository layout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60a6ba42-9755-43ac-8d02-5380d84c5fd0
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 60a6ba42-9755-43ac-8d02-5380d84c5fd0
Summary
dotnet-android-internalto the official 1ES governed pipeline template while preserving its triggers, stage graph, pool images, signing flow, artifact names, and package-test JDK selection.@selfand classify auxiliary repositories for SDL scanning.dotnet/macios-devtoolsrepository wherever a second checkout exists only to keep the primary repository ats/android. This covers the internal, public, official/shared, and nightly pipelines; comments document why the checkout is required. Real MAUI integration jobs continue to check outdotnet/maui.Validation
c33b84759: 38 jobs passed and all hosted macOS jobs completed with zero low-disk warnings.mainbuild; no migration, checkout-shim, or disk-cleanup regression was found.