Repository navigation
[fix-finder] Clarify Parameter default interface compatibility - #12413
Merged
jonathanpeppers merged 1 commit intoAug 18, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
requested review from
jonathanpeppers and
simonrozsival
as code owners
August 18, 2026 02:22
jonathanpeppers
approved these changes
Aug 18, 2026
jonathanpeppers
deleted the
nightly-fix/parameter-dim-comment-f37dca36062096e3
branch
August 18, 2026 12:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Java.Lang.Reflect.Parameter.IsAnnotationPresentstill had a 2017 FIXME saying to remove the member once C# gained default interface method support. C# now supports DIM, but removing this shipped class member would break source compatibility because default interface methods are only callable through an interface-typed receiver.Fix
Replace the stale FIXME in
src/Mono.Android/Java.Lang.Reflect/Parameter.cswith a concise explanation of why the explicit class member must remain.Validation
AndroidSdkDirectory=/home/runner/android-toolchain/sdk AndroidNdkDirectory=/home/runner/android-toolchain/ndk ./build.sh Prepare— passed../dotnet-local.sh build /tmp/gh-aw/agent/parameter-validation/ParameterValidation.csproj --nologo --no-restore— passed with 0 warnings and 0 errors using the actual changed source file.Mono.Android.csprojbuild reached C# compilation but exceeded the runner's memory limit (cscexit 137), including when run single-node; no source diagnostics were emitted.Fix-finder metadata
00-todo-fixme-hack30/30(actionability:10, safety:10, scope:10)Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
southcentralus0.in.applicationinsights.azure.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.