Repository navigation
AOT 3: Move authentication registration to an AOT-safe Abstractions registry #4821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0b2c4a8
Move authentication registration to an AOT-safe Abstractions registry
paulmedynski 066cd54
Address authentication registry feedback for #4821
paulmedynski c5e74a0
Report missing authentication providers as SqlException
paulmedynski c46921a
Align registry schema tests with parent parsing policy
paulmedynski a32912f
Align provider schema tests with parent recovery policy
paulmedynski e3ebb06
Preserve fatal Azure loader failures for #4821
paulmedynski 1f931fb
Make Azure loader tests deterministic on netfx
paulmedynski d307444
Fix Azure loader overload lookup in tests (#4821)
paulmedynski 63eb549
Handle authentication configuration failures independently (#4821)
paulmedynski a8f6b9e
Fix authentication registry review feedback for #4821
paulmedynski a97209f
Preserve authentication failure isolation and callback safety (#4821)
paulmedynski 76440c4
Align Azure discovery tests with authentication failure isolation
paulmedynski f95cd1f
Fix trimmed authentication discovery guidance (#4821)
paulmedynski 638d0b8
Merge main into dev/paul/aot/phase-1.3
paulmedynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
src/Microsoft.Data.SqlClient.Extensions/Abstractions/doc/SqlAuthenticationInitializer.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| <!-- | ||
| Licensed to the .NET Foundation under one or more agreements. | ||
| The .NET Foundation licenses this file to you under the MIT license. | ||
| See the LICENSE file in the project root for more information. | ||
| --> | ||
| <docs> | ||
| <members name="SqlAuthenticationInitializer"> | ||
| <SqlAuthenticationInitializer> | ||
| <summary>Initializes authentication providers configured in app.config.</summary> | ||
| <remarks> | ||
| Configured initializers run synchronously during registry bootstrap without holding the | ||
| lookup/publication lock. Concurrent and reentrant calls observe providers published so far. | ||
| Only registrations made on the initializer's own thread receive configuration precedence. | ||
| This uses the current managed thread ID, not logical async context or causal ownership. | ||
| Work queued to another thread, including Task.Run work that this method waits for, uses | ||
| application precedence and normal recoverable-error handling (SetProvider returns false). | ||
| Same-thread calls made before an asynchronous operation yields still receive initializer | ||
| handling while Initialize is running. Continuations on another thread do not. | ||
| Initializer status ends when Initialize returns or throws. The registry does not await | ||
| queued work or async-void continuations, and failures from that work are not automatically | ||
| captured as initializer failures. GetProvider does not use this thread-ID check. | ||
| Recoverable initialization or registration failures stop this initializer and are traced, | ||
| but later configured providers are still attempted. Defaults cannot fill | ||
| otherwise-unregistered methods after initializer failure because its intended methods | ||
| are unknown. Explicit application registration can recover a missing method. | ||
| Fatal failures propagate and are not cached by registry bootstrap. If execution continues, | ||
| later access can retry bootstrap and repeat initializer side effects. | ||
| Earlier registrations and initializer side effects are not | ||
| rolled back. Enable tracing before the first registry access to capture these failures; | ||
| recoverable initialization failures are not retried until the application restarts. | ||
| </remarks> | ||
| </SqlAuthenticationInitializer> | ||
| <ctor> | ||
| <summary>Creates an authentication initializer.</summary> | ||
| </ctor> | ||
| <Initialize> | ||
| <summary>Registers application-configured authentication providers.</summary> | ||
| <remarks> | ||
| This method executes without the lookup/publication lock. Concurrent and reentrant | ||
| lookups observe providers published so far and can return null before a method has been | ||
| initialized. Configuration precedence applies only to registrations made on this thread. | ||
| Complete required registrations synchronously before returning; asynchronous work does not | ||
| inherit initializer status through ExecutionContext flow. | ||
| </remarks> | ||
| </Initialize> | ||
| </members> | ||
| </docs> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.