Merge | TdsParser functional changes

[edwardneal]

Description

This should cover all necessary functional changes to TdsParser. With these changes merged, the class as a whole should be ready to merge after TdsParserStateObject is dealt with.

Not all of these changes are functional - some are simply necessary to see the real ones clearly. Possibly impactful commits here are:

• 878fcd4: when TdsParser was writing ints and there was space in the packet buffer, WriteInt would write the bytes to a stackalloc'd Span<byte> and then copy into the buffer. I've eliminated the unnecessary intermediary span, and we now write directly into the buffer.
• a8be2f1: netfx had more detailed error messages when the parsing of a TDS stream failed. This ports those messages over to netcore.
• 01b02db: netfx will currently enforce the validation of a server's SSL certificate if Trust Server Certificate is false and the connection's AccessToken or AccessTokenCallback is set, but netcore doesn't currently check the AccessTokenCallback property. This commit changes the behaviour of netcore to match netfx.

There's also one other commit (6d98357) which looks more impactful than it is. s_xmlMetadataSubstituteSequence and s_jsonMetadataSubstituteSequence are the same length, so there's no runtime impact here.

Issues

Relates to #1261.

Testing

Unit tests passed locally.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[paulmedynski]

Looks good, with a few questions/suggestions.

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[benrr101]

All looks good to me!

[benrr101]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[paulmedynski]

@edwardneal - I think a merge from main will help clear up some of these CI failures.

[edwardneal]

Thanks @paulmedynski - I've just merged, can you re-run CI please?

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[paulmedynski]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[codecov]

Codecov Report

❌ Patch coverage is 18.01802% with 182 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.83%. Comparing base (cd3dbd1) to head (c421d87).
⚠️ Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs	12.38%	92 Missing ⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs	23.07%	90 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3555      +/-   ##
==========================================
- Coverage   65.48%   61.83%   -3.66%     
==========================================
  Files         275      267       -8     
  Lines       61518    61338     -180     
==========================================
- Hits        40288    37931    -2357     
- Misses      21230    23407    +2177     

Flag	Coverage Δ
addons	?
netcore	63.90% <12.38%> (-3.75%)	⬇️
netfx	63.95% <23.07%> (-5.26%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[benrr101]

Let's gooooooooooooooooo 🚀