Skip to content

Localize exception messages in Microsoft.Data.SqlClient.Extensions.Azure #4904

Open

Description

@priyankatiwari08

Summary

Exception messages thrown by Microsoft.Data.SqlClient.Extensions.Azure (for example in ActiveDirectoryAuthenticationProvider) are hard-coded English strings. Before the provider moved into the extension package, several of these messages came from localized resources in Microsoft.Data.SqlClient (for example SQL_Timeout_Active_Directory_Interactive_Authentication and SQL_Timeout_Active_Directory_DeviceFlow_Authentication, referenced by an existing TODO in AcquireTokenInteractiveDeviceFlowAsync).

Proposal

Add a localized resource infrastructure to the Azure extension package and move its existing and new exception messages to it, including the WAM missing-parent-window guidance added in #4858.

Raised from review feedback: #4858 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions