Refactor console logger and catch app provisioning exceptions #2189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahalzel
changed the title
deepchoudhery
requested changes
Jan 4, 2023
Member
deepchoudhery
left a comment
deepchoudhery
left a comment
There was a problem hiding this comment.
some questions, maybe some minor changes but mostly LGTM.
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
...SIdentityScaffolding/Microsoft.DotNet.MSIdentity/DeveloperCredentials/MsalTokenCredential.cs
Show resolved
Hide resolved
...t.DotNet.MSIdentity/MicrosoftIdentityPlatform/MicrosoftIdentityPlatformApplicationManager.cs
Show resolved
Hide resolved
...t.DotNet.MSIdentity/MicrosoftIdentityPlatform/MicrosoftIdentityPlatformApplicationManager.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/Tool/MsAADTool.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/Tool/AppProvisioningTool.cs
Show resolved
Hide resolved
deepchoudhery
pushed a commit
that referenced
this pull request
Jan 6, 2023
* Refactor console logger * Exit environment after logging failure * Add try/catch to app registration creation * Refactor LogFailure to LogFailureAndExit
deepchoudhery
added a commit
that referenced
this pull request
Jan 6, 2023
* output error for app registrations, and formatting nit (#2129) * Fix output for app registrations (#2144) Adding issue: #2146 * Log token authentication failure to JsonResponse, Refactor getting app registrations (#2149) * Refactor getting app registrations * Fix test * Refactor ConsoleLogger failure logging * Fix newline (#2181) * bumping dotnet-msidentity version * Refactor console logger and catch app provisioning exceptions (#2189) * Refactor console logger * Exit environment after logging failure * Add try/catch to app registration creation * Refactor LogFailure to LogFailureAndExit Co-authored-by: Zachary Halzel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactors to ConsoleLogger.cs, including passing in the CommandName.
Catch exceptions that may be thrown while creating a new app registration (for example, permissions ServiceException), then log failure.
Also ensuring that Environment.Exit is called after logging failure, so that the JSON response will be parsed correctly in VS. There were sometimes multiple JSON responses and that caused a parsing error.