Adding Blazor Wasm Hosted scenario #1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahalzel
force-pushed
the
dev/zahalzel/hosted
branch
4 times, most recently
from
99b47fb to
2ee30c9
Compare
zahalzel
force-pushed
the
dev/zahalzel/hosted
branch
from
2ee30c9 to
f38e7a1
Compare
deepchoudhery
requested changes
Apr 21, 2022
Member
deepchoudhery
left a comment
deepchoudhery
left a comment
There was a problem hiding this comment.
LGTM, def get some testing in first though.
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/CodeReaderWriter/ProjectModifier.cs
Outdated
Show resolved
Hide resolved
...t.DotNet.MSIdentity/MicrosoftIdentityPlatform/MicrosoftIdentityPlatformApplicationManager.cs
Outdated
Show resolved
Hide resolved
...t.DotNet.MSIdentity/MicrosoftIdentityPlatform/MicrosoftIdentityPlatformApplicationManager.cs
Outdated
Show resolved
Hide resolved
...t.DotNet.MSIdentity/MicrosoftIdentityPlatform/MicrosoftIdentityPlatformApplicationManager.cs
Outdated
Show resolved
Hide resolved
...entityScaffolding/Microsoft.DotNet.MSIdentity/ProjectDescription/ProjectDescriptionReader.cs
Outdated
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/Tool/AppProvisioningTool.cs
Show resolved
Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/Tool/AppProvisioningTool.cs
Outdated
Show resolved
Hide resolved
zahalzel
force-pushed
the
dev/zahalzel/hosted
branch
from
514f112 to
281d988
Compare
deepchoudhery
pushed a commit
that referenced
this pull request
May 9, 2022
* Adding Blazor Wasm Hosted scenario * Refactor hosted parameters * Add csproj extension
deepchoudhery
added a commit
that referenced
this pull request
May 9, 2022
* Add Downstream API option for Blazor WASM code modifier config (#1871) * updates * Multiline json and downstream API blazor wasm code modifier changes * fix configs * PR comments * bumping System.Security.Cryptography.X509Certificates version (#1873) * bump up X509CertificatesVersion package version * adding to Directory.Build.props. * throwing exception if GetConnectionString returns null. (#1876) * Adding Blazor Wasm Hosted scenario (#1878) * Adding Blazor Wasm Hosted scenario * Refactor hosted parameters * Add csproj extension * Enabling nullable templates (#1887) * removing nullable disable and making templates nullable friendly * removing nullable disable and making templates nullable friendly * all but identity scaffolder support nullable * minor updates * bumping Versions.props Co-authored-by: Zachary Halzel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for configuring Blazor WASM Hosted scenario from VS.
Testing:
Testing will be much easier when the changes are merged in VS