Skip to content

ScaffoldingServer: do not dispose of null members #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepchoudhery merged 4 commits into from
Dec 24, 2021
Merged

ScaffoldingServer: do not dispose of null members #1763

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
966108a
ScaffoldingServer: do not dispose of null members
yecril71pl Dec 21, 2021
b500a83
typo fix
yecril71pl Dec 21, 2021
a455270
explicit IDisposable[]
yecril71pl Dec 21, 2021
284892b
Use ?.Dispose
yecril71pl Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tools/dotnet-aspnet-codegenerator/ScaffoldingServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,7 @@ protected virtual void Dispose(bool disposing)
if (disposing)
{
_server.Stop();
_writer.Dispose();
_reader.Dispose();
_socket.Dispose();
foreach (var d in new IDisposable[] { _writer, _reader, _socket }) if (d is IDisposable) d.Dispose();
}

disposedValue = true;
Expand Down