Skip to content

Add tracing to Command.Execute #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepchoudhery merged 4 commits into from
Jan 31, 2022
Merged

Add tracing to Command.Execute #1737

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04237a2
Add tracing to Command.Execute
yecril71pl Dec 13, 2021
1cf7c1f
Really add _logger
yecril71pl Dec 13, 2021
62f0ac7
static readonly ConsoleLogger
yecril71pl Dec 17, 2021
b17d678
minor tweaks as requested
yecril71pl Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/Shared/Microsoft.DotNet.Scaffolding.Shared/Cli.Utils/Command.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Diagnostics;
using System.Linq;
using System.Runtime.CompilerServices;
using Microsoft.DotNet.Scaffolding.Shared;

namespace Microsoft.Extensions.Internal
{
Expand All @@ -15,6 +16,7 @@ internal class Command
private bool _running = false;
private Action<string> _stdErrorHandler;
private Action<string> _stdOutHandler;
private static readonly ConsoleLogger _logger = new ConsoleLogger ();

internal static Command CreateDotNet(string commandName, IEnumerable<string> args)
{
Expand Down Expand Up @@ -63,9 +65,18 @@ public Command WithEnvironmentVariable(string name, string value)
return this;
}

public override string ToString()
{
var psi = _process .StartInfo;
return $"{ psi .FileName } { psi .Arguments }";
}

public CommandResult Execute()
{
ThrowIfRunning();
Command._logger.LogMessage(
$"Executing external command:\n{ this }", LogMessageLevel .Trace
);
_running = true;
_process.EnableRaisingEvents = true;

Expand Down