Skip to content

Conversation

@HaoK
Copy link
Member

@HaoK HaoK commented Feb 9, 2021

@HaoK HaoK requested review from a team and deepchoudhery February 9, 2021 22:55
@mkArtakMSFT
Copy link

Thanks @HaoK.
I assume you just copied over the markup from the identity UI pages as is?

Copy link
Member

@deepchoudhery deepchoudhery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaoK
Copy link
Member Author

HaoK commented Feb 10, 2021

@mkArtakMSFT unfortunately the files aren't identical so its a bit of a manual port of the changes

@mkArtakMSFT
Copy link

Ok I think it's safe to merge given that it's a set of HTML only changes.

@deepchoudhery deepchoudhery merged commit a8e131f into main Feb 11, 2021
@deepchoudhery deepchoudhery deleted the haok/h1 branch February 11, 2021 00:42
@deepchoudhery deepchoudhery mentioned this pull request Feb 11, 2021
deepchoudhery added a commit that referenced this pull request Feb 12, 2021
* reverting to 5.0 sdk, 5.0 tfm until 6.0 stablizes (#1492)

* added lower case check for package paths (#1493)

* Port Identity UI accessibility fixes (#1502)

* added Publishing.props to update to V3 publish (#1504)

* Fixup feeds (#1498)

Co-authored-by: Matt Mitchell <[email protected]>
Co-authored-by: Deep Choudhery <[email protected]>

Co-authored-by: Hao Kung <[email protected]>
Co-authored-by: dotnet bot <[email protected]>
Co-authored-by: Matt Mitchell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants