Skip to content

Conversation

@Emdot
Copy link
Contributor

@Emdot Emdot commented Feb 6, 2021

Updated the method header documentation to be more relevant to a .NET consumer, rather than being in terms of the underlying Docker Engine API calls. This covers IContainerOperations and IImageOperations.

If this is acceptable I'll plan to document more.

@dnfadmin
Copy link

dnfadmin commented Feb 6, 2021

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@jterry75 jterry75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thank you very much!

@Emdot
Copy link
Contributor Author

Emdot commented Feb 18, 2021

Looks like this is ready to merge.

@jterry75
Copy link
Contributor

@galvesribeiro - PTAL. LGTM

Copy link
Member

@galvesribeiro galvesribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@galvesribeiro galvesribeiro merged commit 0d13c41 into dotnet:master Feb 19, 2021
@Emdot Emdot deleted the documentation branch February 19, 2021 05:56
@dgvives
Copy link
Contributor

dgvives commented Feb 22, 2021

Just seen this, it was merged before I had the chance.
@Emdot I encourage you to continue with so fine contributions

@Emdot
Copy link
Contributor Author

Emdot commented Feb 23, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants