Skip to content

Fix clangsharp_Cursor_getDefinition not handling declarations with no definition #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 1 commit into from
Sep 5, 2021
+17 −20
Merged

Fix clangsharp_Cursor_getDefinition not handling declarations with no definition #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions sources/libClangSharp/ClangSharp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,29 +1032,26 @@ CXType clangsharp_Cursor_getDefaultArgType(CXCursor C) {
CXCursor clangsharp_Cursor_getDefinition(CXCursor C) {
if (isDeclOrTU(C.kind)) {
const Decl* D = getCursorDecl(C);
const Decl* DD = nullptr;

if (const FunctionDecl* FD = dyn_cast<FunctionDecl>(D)) {
return MakeCXCursor(FD->getDefinition(), getCursorTU(C));
}

if (const ObjCInterfaceDecl* OCID = dyn_cast<ObjCInterfaceDecl>(D)) {
return MakeCXCursor(OCID->getDefinition(), getCursorTU(C));
}

if (const ObjCProtocolDecl* OCPD = dyn_cast<ObjCProtocolDecl>(D)) {
return MakeCXCursor(OCPD->getDefinition(), getCursorTU(C));
}

if (const TagDecl* TD = dyn_cast<TagDecl>(D)) {
return MakeCXCursor(TD->getDefinition(), getCursorTU(C));
}

if (const VarDecl* VD = dyn_cast<VarDecl>(D)) {
return MakeCXCursor(VD->getDefinition(), getCursorTU(C));
}
DD = FD->getDefinition();
} else if (const ObjCInterfaceDecl* OCID = dyn_cast<ObjCInterfaceDecl>(D)) {
DD = OCID->getDefinition();
} else if (const ObjCProtocolDecl* OCPD = dyn_cast<ObjCProtocolDecl>(D)) {
DD = OCPD->getDefinition();
} else if (const TagDecl* TD = dyn_cast<TagDecl>(D)) {
DD = TD->getDefinition();
} else if (const VarDecl* VD = dyn_cast<VarDecl>(D)) {
DD = VD->getDefinition();
} else {
return clang_getCursorDefinition(C);
}

return DD ? MakeCXCursor(DD, getCursorTU(C)) : clang_getNullCursor();
} else {
return clang_getCursorDefinition(C);
}

return clang_getCursorDefinition(C);
}

CXCursor clangsharp_Cursor_getDependentLambdaCallOperator(CXCursor C) {
Expand Down