Skip to content

Add unchecked handling for reinterpret_cast #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannergooding merged 1 commit into from
Jan 19, 2021
Merged

Add unchecked handling for reinterpret_cast #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions sources/ClangSharp.PInvokeGenerator/PInvokeGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2629,14 +2629,20 @@ private bool IsUnchecked(string targetTypeName, Stmt stmt)
// case CX_StmtClass.CX_StmtClass_CXXFunctionalCastExpr:
// case CX_StmtClass.CX_StmtClass_CXXConstCastExpr:
// case CX_StmtClass.CX_StmtClass_CXXDynamicCastExpr:
// case CX_StmtClass.CX_StmtClass_CXXReinterpretCastExpr:

case CX_StmtClass.CX_StmtClass_CXXReinterpretCastExpr:
{
var reinterpretCastExpr = (CXXReinterpretCastExpr)stmt;

return IsUnchecked(targetTypeName, reinterpretCastExpr.SubExprAsWritten)
|| IsUnchecked(targetTypeName, reinterpretCastExpr.Handle.Evaluate);
}

// case CX_StmtClass.CX_StmtClass_ObjCBridgedCastExpr:

case CX_StmtClass.CX_StmtClass_ImplicitCastExpr:
{
var implicitCastExpr = (ImplicitCastExpr)stmt;
var implicitCastExprTypeName = GetRemappedTypeName(implicitCastExpr, context: null, implicitCastExpr.Type, out _);

return IsUnchecked(targetTypeName, implicitCastExpr.SubExprAsWritten)
|| IsUnchecked(targetTypeName, implicitCastExpr.Handle.Evaluate);
Expand Down
17 changes: 17 additions & 0 deletions tests/ClangSharp.PInvokeGenerator.UnitTests/VarDeclarationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,5 +279,22 @@ public static unsafe partial class Methods
await ValidateGeneratedBindingsAsync(inputContents, expectedOutputContents);
}

[Fact]
public async Task UncheckedReinterpretCastMacroTest()
{
var inputContents = $@"#define Macro1 reinterpret_cast<int*>(-1)";

var expectedOutputContents = $@"namespace ClangSharp.Test
{{
public static unsafe partial class Methods
{{
[NativeTypeName(""#define Macro1 reinterpret_cast<int*>(-1)"")]
public static readonly int* Macro1 = unchecked((int*)(-1));
}}
}}
";

await ValidateGeneratedBindingsAsync(inputContents, expectedOutputContents);
}
}
}