Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds compiler error reporting when the target compiler doesn't meet analyzer and source generator requirements. The changes enforce stricter build behavior by treating certain analyzer-related warnings as errors.
Key changes:
- Added warning-as-error configuration for analyzer compatibility issues (CS8785, CS9057)
- Fixed typo in MSBuild property name (
WarningAsErrors→WarningsAsErrors)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/DotNetCampus.CommandLine/Package/build/Package.props | Added WarningsAsErrors configuration to treat analyzer warnings CS8785 and CS9057 as errors |
| Directory.Build.props | Fixed typo in property name and updated comment from Chinese to English |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lindexi
approved these changes
Nov 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.