-
Notifications
You must be signed in to change notification settings - Fork 3
Support multiple frameworks #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for multiple .NET frameworks by expanding target frameworks from net8.0 and net6.0 to include net5.0, netcoreapp3.1, and netstandard2.0. This enables the library to run on a broader range of .NET versions while maintaining compatibility with newer features through conditional compilation.
Key changes:
- Added conditional compilation directives throughout the codebase to handle API differences across framework versions
- Updated test assertions from
Assert.ThrowsExceptiontoAssert.ThrowsExactlyfor improved test precision - Introduced centralized package management using Directory.Packages.props
Reviewed Changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DotNetCampus.CommandLine/DotNetCampus.CommandLine.csproj | Added net5.0, netcoreapp3.1, and netstandard2.0 target frameworks with conditional AOT compatibility |
| Directory.Packages.props | New centralized package version management file |
| Directory.Build.props | Enabled central package management and added NU1507 warning suppression |
| Multiple test files | Updated assertion methods from ThrowsException to ThrowsExactly |
| Multiple source files | Added conditional compilation for framework-specific APIs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.