Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds reminder comments to the generated interceptor methods, warning users to decorate their command object types with [Option] or [Value] attributes to ensure related builder types are available.
- Inserted inline reminders before each generated return statement in three methods.
- Aims to prevent compile failures when no properties are annotated.
Comments suppressed due to low confidence (1)
src/DotNetCampus.CommandLine.Analyzer/Generators/InterceptorGenerator.cs:148
- [nitpick] The inline comment is written in Chinese and may not be accessible to non-Chinese speaking contributors. Consider using English for code comments to improve accessibility and maintain consistency across the codebase.
// 请确保 {{model.CommandObjectType.Name}} 类型中至少有一个属性标记了 [Option] 或 [Value] 特性;
src/DotNetCampus.CommandLine.Analyzer/Generators/InterceptorGenerator.cs
Show resolved
Hide resolved
lindexi
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #51