Format and lint all node-hub components with ruff #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NellyWhads
changed the title
|
I can also add in a CI stage for |
|
I think it would be great indeed to check it in the CI/CD |
|
@haixuanTao - rebased and applied - GHA go brr. |
phil-opp
added
the
waiting-for-review
haixuanTao
reviewed
Jun 2, 2025
Comment on lines
+27
to
+48
|
|
||
| lint: | ||
| runs-on: ubuntu-24.04 | ||
| needs: [find-jobs] | ||
| name: Lint | ||
| strategy: | ||
| fail-fast: ${{ github.event_name != 'workflow_dispatch' && !(github.event_name == 'release' && startsWith(github.ref, 'refs/tags/')) }} | ||
| matrix: | ||
| folder: ${{ fromJson(needs.find-jobs.outputs.folders )}} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Install the latest version of uv | ||
| uses: astral-sh/setup-uv@v5 | ||
| with: | ||
| enable-cache: true | ||
|
|
||
| - name: Run linting | ||
| working-directory: node-hub/${{ matrix.folder }} | ||
| run: | | ||
| uv tool install ruff | ||
| ruff check . |
There was a problem hiding this comment.
FYI, this is not necessary as we already have it in our node hub script:
dora/.github/workflows/node_hub_test.sh
Line 89 in 1f35724
:)
|
Triage: What's the status of this PR? Is this still needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruff'sErule to all componentsruff formaton all componentsEgroup of linting violations adhering to file-local coding paradigms as closely as possibleHaven't assigned myself to be working on #878 since I'm a little unsure if the maintainers will be comfortable with the
ruff formaton the Pythonic components.