-
Notifications
You must be signed in to change notification settings - Fork 233
Add macOS-only mlx-lm node to node-hub (#882) #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@haixuanTao The CI failed due to |
|
Can you put it in the skip folder? See:
|
|
@haixuanTao skipping tests wasn't enough because the |
|
That makes sense. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks in advance
|
Triage: I resolved the conflict with the |
This PR addresses issue #882 by adding support for
mlx-lmin the dora node-hub.Changes:
mlx-lmnode for macOS compatibility (node-hub/mlx-lm.py).mlx-lmmacOS-only withplatform.system()check to skip execution on Linux/Windows, fixing CI failures.mlx-lmversion 0.23.0.Notes:
mlx-vlmsupport is not included and can be addressed separately.Addresses #882 (partially, as
mlx-vlmis not implemented).@haixuanTao Please review this updated PR for adding
mlx-lmsupport.