-
Notifications
You must be signed in to change notification settings - Fork 233
Bump dora to v0.3.13 #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bump dora to v0.3.13 #1154
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d6c5ab9
bump version to v0.3.13
haixuanTao a1f4341
Bump message format version to publish new version
haixuanTao 9354fac
remove dora-record from example as it is no longer part of the core l…
haixuanTao 96630df
Add stubs for node config
haixuanTao 678bc26
Add a marker for video streaming
haixuanTao 686fe24
bump pinned commit
haixuanTao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for dora-rs devleopment.
This change causes imcompatible message version via old nodes and new nodes like:
I think it would be better if this change is done in a major or minor version up, not in a patch version up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand. I think in the future, we'll do minor version up to keep semver compatibility. Sorry!
DO you need help with upgrading nodes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this just by upgrading all the nodes and dora-cli!
I've just commented on this for better ecosystem management☺️
Thank you.