Replace names dependency with petname crate
#1146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `names` is unmaintained (last release was 2022) and has some outdated dependencies. The `petname` crate is more powerful and actively maintained, so let's switch to it.
haixuanTao
approved these changes
Sep 25, 2025
Merged
haixuanTao
added a commit
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
namescrate is unmaintained (last release was 2022) and has some outdated dependencies.The
petnamecrate is more powerful and actively maintained, so let's switch to it.This PR resolves a security vulnerability by removing the unmaintained
attycrate from our dependency tree.