Error if node with git field was not built before dataflow start
#1089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The working directory of nodes with git fields is only decided on `dora build` because that's where we translate the branch/tag name into the commit hash. Before, we fell back to using the base working directory if no build was done. However, this is confusing since the reason for the different working directory is not communicated in any. This commit throws an error if no build happened before starting a dataflow with git nodes.
To make it more obvious what's going on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The working directory of nodes with git fields is only decided on
dora buildbecause that's where we translate the branch/tag name into the commit hash.Before, we fell back to using the base working directory if no build was done. However, this is confusing since the reason for the different working directory is not communicated in any.
This commit throws an error if no build happened before starting a dataflow with git nodes.