Skip to content

correct nodejs Render return typedef from boolean|object to false|{...} #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2025
Merged

correct nodejs Render return typedef from boolean|object to false|{...} #88

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f185a68
correct nodejs Render return typedef from `boolean|object` to `false|…
erictheswift Sep 4, 2025
7007ae7
fix prettier
erictheswift Sep 5, 2025
3e7d112
adjust help fallback title to library name
erictheswift Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nodejs/src/DisplayHelp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const DisplayHelp = () => {
const { string: headline } = Render('cfonts', {
align: 'left',
gradient: ['red', 'green'],
});
}) || { string: '<render failed>'};

console.log(
` ${headline}` +
Expand Down
12 changes: 6 additions & 6 deletions nodejs/src/Render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,13 @@ const { Log } = require('./Log.js');
* @param {number} size.width - The width of the terminal
* @param {number} size.height - The height of the terminal
*
* @typedef {(object|boolean)} ReturnObject
* @property {string} string - The pure string for output with all line breaks
* @property {array} array - Each line of output in an array
* @property {number} lines - The number of lines
* @property {object} options - All options used
* @typedef {object} ReturnObject
* @property {string} string - The pure string for output with all line breaks
* @property {Array<string>} array - Each line of output in an array
* @property {number} lines - The number of lines
* @property {object} options - All options used
*
* @return {ReturnObject} - CLI output of INPUT to be consoled out
* @return {ReturnObject|false} - CLI output of INPUT to be consoled out
*/
const Render = (input, SETTINGS = {}, debug = DEBUG.enabled, debuglevel = DEBUG.level, size = Size) => {
Debugging.report(`Running render`, 1);
Expand Down
Loading