Remove MvcOptions from SchemaGenerator#3242
Merged
martincostello merged 7 commits intodomaindrivendev:masterfrom Feb 4, 2025
Merged
Remove MvcOptions from SchemaGenerator#3242martincostello merged 7 commits intodomaindrivendev:masterfrom
martincostello merged 7 commits intodomaindrivendev:masterfrom
Conversation
remove any usages of MvcOptions in 'SchemaGenerator'. It should not be a breaking change since bool expression is 'true' by definition if 'SuppressImplicitRequiredAttributeForNonNullableReferenceTypes=false'
EvgeniyZ
commented
Jan 30, 2025
EvgeniyZ
commented
Jan 30, 2025
...Swashbuckle.AspNetCore.SwaggerGen.Test/SchemaGenerator/JsonSerializerSchemaGeneratorTests.cs
Show resolved
Hide resolved
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3242 +/- ##
==========================================
- Coverage 83.62% 82.40% -1.22%
==========================================
Files 76 97 +21
Lines 3182 3587 +405
Branches 538 648 +110
==========================================
+ Hits 2661 2956 +295
- Misses 521 631 +110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/Swashbuckle.AspNetCore.SwaggerGen/DependencyInjection/SwaggerGenOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
...Swashbuckle.AspNetCore.SwaggerGen.Test/SchemaGenerator/JsonSerializerSchemaGeneratorTests.cs
Show resolved
Hide resolved
src/Swashbuckle.AspNetCore.SwaggerGen/SchemaGenerator/SchemaGenerator.cs
Show resolved
Hide resolved
bring back tests
src/Swashbuckle.AspNetCore.SwaggerGen/PublicAPI/PublicAPI.Shipped.txt
Outdated
Show resolved
Hide resolved
...Swashbuckle.AspNetCore.SwaggerGen.Test/SchemaGenerator/JsonSerializerSchemaGeneratorTests.cs
Outdated
Show resolved
Hide resolved
...Swashbuckle.AspNetCore.SwaggerGen.Test/SchemaGenerator/JsonSerializerSchemaGeneratorTests.cs
Outdated
Show resolved
Hide resolved
...Swashbuckle.AspNetCore.SwaggerGen.Test/SchemaGenerator/JsonSerializerSchemaGeneratorTests.cs
Outdated
Show resolved
Hide resolved
…onSerializerSchemaGeneratorTests.cs Co-authored-by: Martin Costello <[email protected]>
…onSerializerSchemaGeneratorTests.cs Co-authored-by: Martin Costello <[email protected]>
…onSerializerSchemaGeneratorTests.cs Co-authored-by: Martin Costello <[email protected]>
martincostello
approved these changes
Feb 4, 2025
src/Swashbuckle.AspNetCore.SwaggerGen/SchemaGenerator/SchemaGenerator.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 31, 2025
This was referenced Feb 23, 2026
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 10.1.4
EltonCoura/skills-secure-repository-supply-chain#25
Open
Open
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 10.1.4
vnikolaiev/skills-secure-repository-supply-chain#10
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 10.1.4
yewaleajay/skills-secure-repository-supply-chain#10
Open
Open
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue or feature being addressed
Fixes #3203
Details on the issue fix or feature implementation
remove any usages of MvcOptions in 'SchemaGenerator'. It should not be a breaking change since bool expression is 'true' by definition if 'SuppressImplicitRequiredAttributeForNonNullableReferenceTypes=false'