fix: Pass props to multi targeting#3107
fix: Pass props to multi targeting#3107martincostello merged 1 commit intodomaindrivendev:masterfrom xC0dex:feature/pass-props-to-multi-targeting
Conversation
|
I guess there's not an easy way to add a test for this, right? |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3107 +/- ##
=======================================
Coverage 90.50% 90.50%
=======================================
Files 76 76
Lines 3116 3116
Branches 515 515
=======================================
Hits 2820 2820
Misses 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
You're right. It’s hard to test as it happens during the |
Pull Request
The issue or feature being addressed
This PR fixes #2706 by passing the defined
Swashbuckle.AspNetCore.propsfile to thebuildMultiTargetingdirectory, which is used for outer builds (Multi targeting).Details on the issue fix or feature implementation
The props file defines that the
OpenApiGenerateDocumentsOnBuildproperty is false by default if it's not set. However, this was not set for multi targeting projects. So the document was generated during the build.