Add support for WithSummary and WithDescription metadata#2414
Conversation
b64efc4 to
cb2f7c6
Compare
|
@domaindrivendev Just pinging for a review now that we're at .NET 7 RC1. I'm happy to either expand this to support the rest of the new Metadata types, leave it as is, or scrap it altogether. Just looking for your thoughts on this. |
|
Hi, why is this still open? |
|
I'd honestly forgotten about this. Ideally I think this should still be reviewed and merged, a quick check indicates that support for WithSummary and WIthDescription hasn't been added yet. (I'll test that out a bit later just in case) |
|
There is quite a large backlog of unreviewed and unmerged changes in this repo from lots of people (I've had #2526 outstanding for months too). |
|
Hello, will this code merged? I want it to use already :) |
|
That's up to the owner of the repository to review the backlog of open pull requests. |
|
Can we finally merge it? |
Based on #2759 (comment), it looks like this repo is on hiatus until a new maintainer can be found. Until then, it's unlikely this will be merged. It looks like this PR is being ported over to a fork of this project, so it could be worth checking that out, or checking out NSwag. |
|
@hwoodiwiss If you rebase on to the default branch to pick up our new CI we can take a look at this for you. |
Adds a default sumamry value to OpenApiOperation's derived from an `IEndpointSummaryMetadata` on the api action
fadb70a to
dd6c603
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2414 +/- ##
==========================================
+ Coverage 91.66% 91.69% +0.03%
==========================================
Files 91 91
Lines 3010 3022 +12
Branches 517 519 +2
==========================================
+ Hits 2759 2771 +12
Misses 251 251
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fixes dotnet/aspnetcore#40753
fixes #2548
Adds support for the MinimalAPI operation metadata functions,
WithSummaryandWithDescription, including CI changes.