Skip to content

Conversation

@Minty-Meeo
Copy link
Contributor

Following a suggestion given by @iwubcode on PR #11709, let's just include all externals as system headers so the warnings from their headers can stop leaking into our warnings.

@Minty-Meeo
Copy link
Contributor Author

Minty-Meeo commented Apr 1, 2023

Okay seems like the buildbots are not on CMake 3.25+

@iwubcode
Copy link
Contributor

iwubcode commented Apr 1, 2023

@OatmealDome
Copy link
Member

OatmealDome commented Apr 2, 2023

Requiring CMake 3.25+ is problematic. Android Studio only comes with CMake 3.22.1 maximum (or at least that's what my copy is telling me).

@Minty-Meeo
Copy link
Contributor Author

Curse Android, always holding back my PRs.

@shuffle2
Copy link
Contributor

shuffle2 commented Apr 2, 2023

For VisualStudio, you can likely use: https://learn.microsoft.com/en-us/cpp/build/reference/external-external-headers-diagnostics?view=msvc-170

this is already implemented in msbuild so should just be able to copy the cmdlines it generates

note that msvc has also has concept of "system" headers as opposed to just "external". at least on msbuild, system is the wrong choice because msbuild does not do full change detection on system headers (which it considers part of the toolchain). so you may want to ensure cmake doesn't have the same semantics.

@JosJuice JosJuice closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants