Resolve various compiler warnings #11534

Pokechu22 · 2023-02-03T01:59:37Z

Many of these warnings are due to variable shadowing from the deglobalization changes. I'm not super happy about this, but I don't see any alternative (the options for -Wshadow aren't fine-grained enough to disable it for lambdas that don't have capturing enabled or for constructor parameters with the same name as members).

The remaining warnings are these:

/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
/mnt/c/users/pokechu22/source/repos/dolphin/Source/Core/Common/Crypto/AES.cpp:253:37: warning: ignoring attributes on template argument ‘__m128i’ [-Wignored-attributes]
/mnt/c/users/pokechu22/source/repos/dolphin/Source/Core/Common/Crypto/SHA1.cpp:169:43: warning: ignoring attributes on template argument ‘__m128i’ [-Wignored-attributes]
/mnt/c/users/pokechu22/source/repos/dolphin/Source/Core/Common/Crypto/SHA1.cpp:247:24: warning: ignoring attributes on template argument ‘__m128i’ [-Wignored-attributes]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/cubeb/cubeb/subprojects/speex/resample.c:674:20: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/cubeb/cubeb/subprojects/speex/resample.c:946:21: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/cubeb/cubeb/subprojects/speex/resample.c:949:20: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/cubeb/cubeb/subprojects/speex/resample.c:1002:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/cubeb/cubeb/subprojects/speex/resample.c:1009:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/cubeb/cubeb/subprojects/speex/resample.c:1019:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/cubeb/cubeb/src/cubeb_alsa.c:8: warning: "_DEFAULT_SOURCE" redefined
/mnt/c/users/pokechu22/source/repos/dolphin/Source/Core/InputCommon/ControllerInterface/DualShockUDPClient/DualShockUDPClient.cpp:599:27: warning: writing 4 bytes into a region of size 1 [-Wstringop-overflow=]
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:10: warning: ‘%s’ directive argument is null [-Wformat-truncation=]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/mGBA/mgba/src/sm83/decoder.c:418:9: warning: ‘decoder’ may be used uninitialized in this function [-Wmaybe-uninitialized]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/mGBA/mgba/src/gb/memory.c:287:63: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/mGBA/mgba/src/arm/decoder.c:565:53: warning: operand of ‘?:’ changes signedness from ‘int32_t’ {aka ‘int’} to ‘uint32_t’ {aka ‘unsigned int’} due to unsignedness of other operand [-Wsign-compare]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/mGBA/mgba/src/gba/renderers/software-bg.c:70:12: warning: ‘localY’ may be used uninitialized in this function [-Wmaybe-uninitialized]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/mGBA/mgba/src/gba/renderers/software-bg.c:69:12: warning: ‘localX’ may be used uninitialized in this function [-Wmaybe-uninitialized]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/mGBA/mgba/src/gba/sio/lockstep.c:454:3: warning: enumeration value ‘SIO_UART’ not handled in switch [-Wswitch]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/mGBA/mgba/src/gba/sio/lockstep.c:454:3: warning: enumeration value ‘SIO_GPIO’ not handled in switch [-Wswitch]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/mGBA/mgba/src/gba/sio/lockstep.c:454:3: warning: enumeration value ‘SIO_JOYBUS’ not handled in switch [-Wswitch]
/mnt/c/users/pokechu22/source/repos/dolphin/Source/Core/VideoCommon/CPUCull.cpp:28: warning: ignoring ‘#pragma STDC FP_CONTRACT’ [-Wunknown-pragmas]
/mnt/c/users/pokechu22/source/repos/dolphin/Source/Core/VideoCommon/PixelShaderGen.cpp:1188:48: warning: narrowing conversion of ‘(unsigned int)stage.pixel_shader_uid_data::<unnamed struct>::tevind’ from ‘unsigned int’ to ‘unsigned int:21’ [-Wnarrowing]
/mnt/c/users/pokechu22/source/repos/dolphin/Externals/expr/include/expr.h:829:13: warning: declaration of ‘char* s’ shadows a parameter [-Wshadow]

Most of these are in external code. The attributes on __m128i ones are something I don't know how to fix (see https://stackoverflow.com/a/49216021 and https://stackoverflow.com/q/12942548; the latter has comments that imply that this shouldn't apply in C++17). The remainder seem to be compiler bugs which I will investigate further: CPUCull has the warning explicitly ignored, but it still shows up; PixelShaderGen doesn't make sense as tevind is a 21-bit bitfield; and the DualShockUDPClient one is complete nonsense as nothing string-related is happening there. I'll report these to the GCC team after I investigate further.

Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp

Source/Core/VideoCommon/CommandProcessor.cpp

Pokechu22 · 2023-02-04T04:44:58Z

The CPUCull one is because the unknown pragma warning comes from the preprocessor (see bug 89038) and is fixed in GCC 13 (see bug 53431), though that has not yet released.

The DualShockUDPClient one is also fixed in GCC 11 (bug 96963) (though it still exists in GCC 10, which is why they haven't marked it as fixed, I think). I happened to be using GCC 10 to test locally.

I created a report for the PixelShaderGen bitfield issue: bug 108670.

BhaaLseN · 2023-02-04T10:57:31Z

Source/Core/Core/IOS/ES/ES.cpp

  auto& core_timing = system.GetCoreTiming();
  s_finish_init_event = core_timing.RegisterEvent(
-      "IOS-ESFinishInit", [](Core::System& system, u64, s64) { GetIOS()->GetES()->FinishInit(); });
+      "IOS-ESFinishInit", [](Core::System& system_, u64, s64) { GetIOS()->GetES()->FinishInit(); });


This one (and the following) don't use the system_ parameter; maybe we should just omit it like the u64/s64 after it?

I'm guessing at some point GetIOS() will be moved to System, so IMO it's still useful to rename it (if we don't come up with an alternative way of dealing with the shadowing warnings).

BhaaLseN · 2023-02-04T10:57:50Z

Source/Core/Core/IOS/IOS.cpp


  s_event_enqueue =
-      core_timing.RegisterEvent("IPCEvent", [](Core::System& system, u64 userdata, s64) {
+      core_timing.RegisterEvent("IPCEvent", [](Core::System& system_, u64 userdata, s64) {


Same down here.

Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp

This code doesn't need to be portable (since the goal is to have a smaller offset for x64 codegen), so if it's not supported there are other problems. Similar code exists in e.g. DSP.cpp.

Otherwise, files that include the header get warning: ‘Discord::s_using_custom_client’ defined but not used.

…s local

…us local

…defined [-Wsequence-point]

…local

…s local

…subscripts]

…n switch [-Wswitch]

…warnings We need to copy padding in most of these cases, and the objects are trivially copyable; however, BitField prevents trivial copy-assignment.

Zopolis4 · 2023-02-10T08:30:57Z

How are you gathering the warnings? (i.e. how did you make that list of the remaining warnings)

Pokechu22 · 2023-02-10T18:36:34Z

In WSL (with GCC):

make clean to force the next build to be from scratch.
make 2>&1 | tee build.log: make to build; 2>&1 to redirect stderr (where warnings are put) to stdout; | tee build.log to write stdout to build.log (but also to the console). Note that this is a single-threaded build; you can also do make -j 8 2>&1 | tee build.log to use 8 cores (or whatever), but then the order of the output won't be deterministic.
grep warning build.log to get the list of warnings.

Pokechu22 force-pushed the warning-fixes-feb-2023 branch from 228d30b to 73c289b Compare February 3, 2023 02:17

phire reviewed Feb 3, 2023

View reviewed changes

Source/Core/DolphinQt/SkylanderPortal/SkylanderPortalWindow.cpp Show resolved Hide resolved

phire reviewed Feb 3, 2023

View reviewed changes

Source/Core/VideoCommon/CommandProcessor.cpp Show resolved Hide resolved

phire reviewed Feb 3, 2023

View reviewed changes

Source/Core/VideoCommon/CommandProcessor.cpp Show resolved Hide resolved

BhaaLseN reviewed Feb 4, 2023

View reviewed changes

iwubcode reviewed Feb 5, 2023

View reviewed changes

Source/Core/VideoCommon/GraphicsModSystem/Runtime/GraphicsModManager.cpp Outdated Show resolved Hide resolved

Pokechu22 force-pushed the warning-fixes-feb-2023 branch from 73c289b to 8ea617d Compare February 6, 2023 05:35

Pokechu22 added 22 commits February 9, 2023 16:23

Suppress -Winvalid-offsetof for PowerPC::PowerPCState

af5013b

This code doesn't need to be portable (since the goal is to have a smaller offset for x64 codegen), so if it's not supported there are other problems. Similar code exists in e.g. DSP.cpp.

Fix warning: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20

b316ce6

Move s_using_custom_client to DiscordPresence.cpp

8b98dd9

Otherwise, files that include the header get warning: ‘Discord::s_using_custom_client’ defined but not used.

Software/Tev: Fix member shadowing warnings

2288ba2

Resolve various "no previous declaration" warnings

49a84cb

VideoInterface: Fix warning: declaration of ‘state’ shadows a previou…

72b4675

…s local

SerialInterface: Fix warning: declaration of ‘state’ shadows a previo…

c555a4f

…us local

GCMemcardDirectory: Fix variable shadowing warning

1465620

EXI_DeviceEthernet: Fix warning: operation on ‘current_rwp’ may be un…

9c52c60

…defined [-Wsequence-point]

DVDInterface: Fix warning: declaration of ‘state’ shadows a previous …

24df509

…local

DSP: Fix warning: declaration of ‘state’ shadows a previous local

8ad7d58

AudioInterface: Fix warning: declaration of ‘state’ shadows a previou…

edcc4a6

…s local

InputCommon/XInput2: Fix shadowing warning

7fafb00

GraphicsModManager: Fix shadowing warning

95bee48

VertexLoaderBase: Fix shadowing warning

39c5d55

Boot: Fix shadowing warning

8d71f54

IOS: Fix shadowing warnings

f1b1f5c

CommandProcessor: Fix shadowing warnings

9559c45

State: Fix shadowing warnings

debed35

TextureDecoder: Fix warning: array subscript has type ‘char’ [-Wchar-…

470115f

…subscripts]

CodeWidget: Fix shadowing warning

5c8d838

MemoryViewWidget: Fix warning: enumeration value ‘Null’ not handled i…

3bd6554

…n switch [-Wswitch]

Pokechu22 added 2 commits February 9, 2023 16:23

BreakPoints: Fix shadowing warning

ac7a175

Suppress memcpy writing to an object with no trivial copy-assignment …

3024ca2

…warnings We need to copy padding in most of these cases, and the objects are trivially copyable; however, BitField prevents trivial copy-assignment.

Pokechu22 force-pushed the warning-fixes-feb-2023 branch from 8ea617d to 3024ca2 Compare February 10, 2023 00:23

phire merged commit dad7a32 into dolphin-emu:master Feb 10, 2023

Pokechu22 mentioned this pull request Mar 23, 2023

Resolve GCC/Clang Warnings #11687

Merged

Medard22 mentioned this pull request Feb 10, 2024

"Resolve various compiler warnings" by Pokechu22 Medard22/Dolphin-MMJR2-VBI#124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Resolve various compiler warnings #11534

Resolve various compiler warnings #11534

Uh oh!

Pokechu22 commented Feb 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pokechu22 commented Feb 4, 2023

Uh oh!

BhaaLseN Feb 4, 2023

Uh oh!

Pokechu22 Feb 6, 2023

Uh oh!

BhaaLseN Feb 4, 2023

Uh oh!

Uh oh!

Zopolis4 commented Feb 10, 2023

Uh oh!

Pokechu22 commented Feb 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants

Resolve various compiler warnings #11534

Resolve various compiler warnings #11534

Uh oh!

Conversation

Pokechu22 commented Feb 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pokechu22 commented Feb 4, 2023

Uh oh!

BhaaLseN Feb 4, 2023

Choose a reason for hiding this comment

Uh oh!

Pokechu22 Feb 6, 2023

Choose a reason for hiding this comment

Uh oh!

BhaaLseN Feb 4, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zopolis4 commented Feb 10, 2023

Uh oh!

Pokechu22 commented Feb 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants