Remove potential memory leak in DokanCreateDiskDevice on allocation failure.#107
Closed
canardos wants to merge 1 commit intodokan-dev:masterfrom
canardos:fix-dokancreatediskdevice-memleak
Closed
Remove potential memory leak in DokanCreateDiskDevice on allocation failure.#107canardos wants to merge 1 commit intodokan-dev:masterfrom canardos:fix-dokancreatediskdevice-memleak
canardos wants to merge 1 commit intodokan-dev:masterfrom
canardos:fix-dokancreatediskdevice-memleak
Conversation
Contributor
Author
|
I've noticed other failure modes in this function that also fail to properly free the DCB and potentially other structures. Closing and will resubmit with further changes |
Contributor
Author
|
Can't reopen due to 361, resubmitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code assumes that if one of
SymbolicLinkNameDiskDeviceNameorFileSystemDeviceNamefails allocation, then the subsequent allocations also failed and does not free them. This may not be the case, resulting in a memory leak.