Skip to content

Conversation

@agubler
Copy link
Member

@agubler agubler commented Nov 14, 2018

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Rewrite resources and index.html when using the history fallback.

Resolves #207

rewrites: [
{
from: /^.*\.(?!html).*$/,
to: (context: any) => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is any because request was added in 1.5.0 but the types are still at 1.3.1

@agubler agubler requested a review from rorticus November 14, 2018 11:08
@agubler agubler added bug next Issue/Pull Request for the next major version labels Nov 14, 2018
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #208 into master will decrease coverage by 0.64%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage    52.7%   52.06%   -0.65%     
==========================================
  Files          10       10              
  Lines         573      582       +9     
  Branches      140      142       +2     
==========================================
+ Hits          302      303       +1     
- Misses        271      279       +8
Impacted Files Coverage Δ
src/main.ts 86.3% <20%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b99c49...ed2cc01. Read the comment docs.

Copy link
Contributor

@rorticus rorticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug next Issue/Pull Request for the next major version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants