Skip to content

Conversation

@agubler
Copy link
Member

@agubler agubler commented Nov 2, 2018

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Ooops I created a bad regex for dojo/widgets.

@codecov
Copy link

codecov bot commented Nov 2, 2018

Codecov Report

Merging #201 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #201      +/-   ##
=========================================
- Coverage   52.88%   52.7%   -0.19%     
=========================================
  Files          10      10              
  Lines         571     573       +2     
  Branches      139     140       +1     
=========================================
  Hits          302     302              
- Misses        269     271       +2
Impacted Files Coverage Δ
src/base.config.ts 22.5% <0%> (-0.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2539b3...6fbef35. Read the comment docs.

Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants