Add service worker support #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow service worker options to be specified in the dojorc. If the file path for an existing service worker is provided, it is copied to the output directory. Otherwise, a service worker file is generated that contains a precache manifest, as well as any specified route handlers. Further, when generating a service worker from the rc, an additional entry point is added to the build that initializes the service worker at startup. Finally, iOS-specific meta tags related to PWAs are added to the application's index.html (requires an upgraded to html-webpack-plugin).
- Update README - Add missing util tests, as well as a functional test for the PWA meta tags - Fix: use `cachePrefix` from dojorc over package.json `name`
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=========================================
- Coverage 63.43% 60.83% -2.6%
=========================================
Files 8 8
Lines 361 383 +22
Branches 67 79 +12
=========================================
+ Hits 229 233 +4
- Misses 127 145 +18
Partials 5 5
Continue to review full report at Codecov.
|
matt-gadd
requested changes
Jun 5, 2018
src/sw-entry.ts
Outdated
| @@ -0,0 +1,5 @@ | |||
| if ('serviceWorker' in navigator) { | |||
Contributor
Author
There was a problem hiding this comment.
It is not; it's in @dojo/webpack-contrib now. Good catch!
matt-gadd
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves most of #96 (adding the
apple-touch-iconmeta tag requires additional voodoo that may be better suited forwebpack-contrib). Adds service worker support when usingdistanddevmodes. Relying on@dojo/webpack-contrib's service worker plugin, application developers can generate a fully-featured service worker via the.dojorcthat supports pre-caching and custom route handling (and is automatically initialized when the app starts), or they can provide the path of an existing service worker file that will be copied to the output directory.Tested locally on both Windows and macOS with a sandbox application, and verified on Windows with
dojo eject.