Skip to content

Conversation

@greg0ire
Copy link
Member

Additionally, implementations of ReflectionService may no longer return null for calls to getClass().

Additionally, implementations of ReflectionService may no longer return
null for calls to getClass().
@greg0ire
Copy link
Member Author

I am tempted to make ReflectionService a class, and have RuntimeReflectionService extend it and be deprecated in favor of it, or even be removed. Thoughts?

@SenseException
Copy link
Member

Because RuntimeReflectionService is the last class implementing ReflectionService? Is the goal to have just one implementation for a ReflectionService?

@greg0ire
Copy link
Member Author

Yeah, AFAIK it's the sole implementation of ReflectionService, so I'm not sure if there is still a point in having ReflectionService be an interface.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Converting ReflectionService to a class is going to be a tough to manage BC break - I don't think it's worth it.

@greg0ire greg0ire merged commit a2a0dae into doctrine:4.0.x Jun 24, 2024
@greg0ire greg0ire deleted the remove-static-reflection branch June 24, 2024 18:00
@greg0ire greg0ire added this to the 4.0.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants