Replace comment with real method signature #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
real-is-uninitialized
branch
from
f32ba8a to
00d4b07
Compare
nicolas-grekas
approved these changes
May 26, 2024
derrabus
reviewed
May 26, 2024
| public function initializeObject(object $obj): void; | ||
|
|
||
| /** Helper method to check whether a lazy loading proxy or persistent collection has been initialized. */ | ||
| public function isUninitializedObject(mixed $value): bool; |
Member
There was a problem hiding this comment.
Is this really mixed or should this be an object at least?
Member
Author
There was a problem hiding this comment.
Really mixed, see discussion on slack channel proxy-integration
Member
Author
There was a problem hiding this comment.
back at my desktop, here is the link: https://doctrine.slack.com/archives/C045LBBNALQ/p1716360854270869
Member
There was a problem hiding this comment.
😕
Not happy about that, but if that's the consensus, … 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.