Skip to content

Conversation

@derrabus
Copy link
Member

Replaces #299.

@derrabus derrabus added Enhancement New feature or request BC Break labels May 21, 2024
@derrabus derrabus added this to the 4.0.0 milestone May 21, 2024
@greg0ire
Copy link
Member

greg0ire commented May 21, 2024

You can remove or simplify CONTRIBUTING.md :)

Inspiration: https://github.com/doctrine/dbal/blob/4.0.x/CONTRIBUTING.md

And you should probably mention the breaking change in UPGRADE.md

@derrabus derrabus force-pushed the remove/common-proxy branch from 6f020bc to 8bcdf91 Compare May 21, 2024 17:14
@derrabus
Copy link
Member Author

I took the lazy path and removed the file. 🙃

@greg0ire
Copy link
Member

Fine by me… can you include a note in UPGRADE.md please? I didn't think about it rightaway, and made an edit afterwards.

@derrabus derrabus force-pushed the remove/common-proxy branch from 8bcdf91 to 82b2a9b Compare May 21, 2024 19:41
@derrabus
Copy link
Member Author

Done!

@derrabus derrabus merged commit 27441f8 into doctrine:4.0.x May 21, 2024
@derrabus derrabus deleted the remove/common-proxy branch May 21, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BC Break Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants