Skip to content

Conversation

@Goazil
Copy link

@Goazil Goazil commented May 16, 2024

This PR should fix an issue with the property isPrivate from inheritance on ReflectionProperty.

In EnumReflectionProperty the method isPrivate should be executed on the originalReflectionProperty to prevent fatal error :

Internal error: Failed to retrieve the reflection object

This commit just override the method and check the privacy on the originalReflectionProperty.

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goazil
Copy link
Author

Goazil commented May 17, 2024

greg0ire
greg0ire previously approved these changes May 17, 2024
@greg0ire greg0ire added the Bug Something isn't working label May 17, 2024
@greg0ire
Copy link
Member

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

  1. git rebase -i origin/3.3.x, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
  2. A window will show up with many lines, replace pick with fixup on every line but the first one
  3. Close your editor, git should do its magic, and you should end up with one commit
  4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

@Goazil Goazil force-pushed the fix-enum-private-reflection branch from d52f7ee to 39ddc95 Compare May 17, 2024 07:39
@greg0ire greg0ire added this to the 3.3.3 milestone May 17, 2024
@greg0ire greg0ire merged commit 267cd9f into doctrine:3.3.x May 17, 2024
@greg0ire
Copy link
Member

Thanks @Goazil

@Goazil Goazil deleted the fix-enum-private-reflection branch May 21, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants