-
-
Notifications
You must be signed in to change notification settings - Fork 74
fix: Failing to retrieve reflection property on enum #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
greg0ire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done. |
|
Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble. How to do that?
|
chore: add test chore: fix typo
d52f7ee to
39ddc95
Compare
|
Thanks @Goazil |
This PR should fix an issue with the property isPrivate from inheritance on
ReflectionProperty.In
EnumReflectionPropertythe methodisPrivateshould be executed on theoriginalReflectionPropertyto prevent fatal error :This commit just override the method and check the privacy on the originalReflectionProperty.