Skip to content

[GH-9380] Bugfix: Delegate ReflectionEnumProperty::getAttributes(). #9381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beberlei merged 5 commits into from
Jan 15, 2022
Merged

[GH-9380] Bugfix: Delegate ReflectionEnumProperty::getAttributes(). #9381

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f84acb
[GH-9380] Bugfix: Delegate ReflectionEnumProperty::getAttributes().
beberlei Jan 14, 2022
5830515
[GH-9380] Add test for retrieving attributes via enum property.
beberlei Jan 14, 2022
3e1ba3d
[GH-9380] Add test for retrieving attributes via enum property.
beberlei Jan 14, 2022
bbf21c8
[GH-9380] Call parent ReflectionProperty ctor for best behavior.
beberlei Jan 14, 2022
c2c5d32
Update tests/Doctrine/Tests/ORM/Functional/EnumTest.php
beberlei Jan 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/Doctrine/ORM/Mapping/ReflectionEnumProperty.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,11 @@ public function __construct(ReflectionProperty $originalReflectionProperty, stri
{
$this->originalReflectionProperty = $originalReflectionProperty;
$this->enumType = $enumType;

parent::__construct(
$originalReflectionProperty->getDeclaringClass()->getName(),
$originalReflectionProperty->getName()
);
}

/**
Expand Down
16 changes: 14 additions & 2 deletions tests/Doctrine/Tests/ORM/Functional/EnumTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

namespace Doctrine\Tests\ORM\Functional;

use Doctrine\ORM\Mapping\Column;
use Doctrine\ORM\Mapping\Driver\AttributeDriver;
use Doctrine\ORM\Mapping\MappingException;
use Doctrine\ORM\Tools\SchemaTool;
Expand All @@ -22,11 +23,11 @@ class EnumTest extends OrmFunctionalTestCase
{
public function setUp(): void
{
parent::setUp();

$this->_em = $this->getEntityManager(null, new AttributeDriver([dirname(__DIR__, 2) . '/Models/Enums']));
$this->_schemaTool = new SchemaTool($this->_em);

parent::setUp();

if ($this->isSecondLevelCacheEnabled) {
$this->markTestSkipped();
}
Expand Down Expand Up @@ -101,4 +102,15 @@ public function provideCardClasses(): array
TypedCard::class => [TypedCard::class],
];
}

public function testGetAttributesDelegate(): void
Comment thread
beberlei marked this conversation as resolved.
Outdated
{
$metadata = $this->_em->getClassMetadata(Card::class);
$property = $metadata->getReflectionProperty('suit');

$attributes = $property->getAttributes();

$this->assertCount(1, $attributes);
$this->assertEquals(Column::class, $attributes[0]->getName());
}
}