Skip to content

Add detach as of list cascade-all operations #9357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SenseException merged 1 commit into from
Jan 12, 2022
Merged

Add detach as of list cascade-all operations #9357

SenseException merged 1 commit into from
Jan 12, 2022

Conversation

@andrew-demb
Copy link
Contributor

@andrew-demb andrew-demb commented Jan 10, 2022

As of XmlExporter (

orm/lib/Doctrine/ORM/Tools/Export/Driver/XmlExporter.php

Lines 270 to 293 in b7d8229

$cascade = [];
if ($associationMapping['isCascadeRemove']) {
$cascade[] = 'cascade-remove';
}
if ($associationMapping['isCascadePersist']) {
$cascade[] = 'cascade-persist';
}
if ($associationMapping['isCascadeRefresh']) {
$cascade[] = 'cascade-refresh';
}
if ($associationMapping['isCascadeMerge']) {
$cascade[] = 'cascade-merge';
}
if ($associationMapping['isCascadeDetach']) {
$cascade[] = 'cascade-detach';
}
if (count($cascade) === 5) {
$cascade = ['cascade-all'];
}
), there is missed cascade-detach operation from the list.

@derrabus derrabus changed the base branch from 2.10.x to 2.11.x January 12, 2022 13:34
@SenseException SenseException merged commit c0a1404 into doctrine:2.11.x Jan 12, 2022
@SenseException
Copy link
Member

SenseException commented Jan 12, 2022

Thank you @andrew-demb

@andrew-demb andrew-demb deleted the patch-1 branch January 12, 2022 21:35
@derrabus derrabus added this to the 2.11.1 milestone Jan 12, 2022
derrabus added a commit to derrabus/orm that referenced this pull request Jan 17, 2022
@derrabus
Merge branch '2.12.x' into 3.0.x
fd2bab9 
* 2.12.x:
  Allow using Enum from different namespace than Entity (doctrine#9384)
  Corrected ORM version and added missing dependency (doctrine#9386)
  PHPStan 1.4.0 (doctrine#9385)
  [doctrineGH-9380] Bugfix: Delegate ReflectionEnumProperty::getAttributes(). (doctrine#9381)
  Support enum cases as parameters (doctrine#9373)
  Add detach as of list cascade-all operations (doctrine#9357)
@github-actions github-actions bot mentioned this pull request Jan 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SenseException SenseException SenseException approved these changes

Assignees

No one assigned

Labels

Documentation

Projects

None yet

Milestone

2.11.1

Development

Successfully merging this pull request may close these issues.

3 participants

@andrew-demb @SenseException @derrabus